From anandb at ripe.net Wed Aug 13 15:21:34 2014 From: anandb at ripe.net (Anand Buddhdev) Date: Wed, 13 Aug 2014 17:21:34 +0200 Subject: [dsc] DSC's collector fails to compile on CentOS 7 Message-ID: <53EB827E.3010807@ripe.net> Hello DSC users and devs, I'm trying to compile DSC on CentOS 7, and it's failing. I'm building dsc-201203250530. The specific error I get is: # cd /builddir/build/BUILD/dsc-201203250530/collector/dsc/ # ./configure ... [ configure output ] ... # make Makefile:6: *** missing separator. Stop. This exact sequence works fine on CentOS 6, but fails on CentOS 7. If I diff the Makefiles produced by CentOS 6 and CentOS 7, I see: < LDFLAGS += # from configure < CFLAGS += -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic # from configure --- > LDFLAGS += -Wl,-z,relro # from configure > CFLAGS += -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic # from configure The other difference is that CentOS 6 has make version 3.81, and CentOS 7 has make version 3.82. I can't see anything obviously wrong with the Makefile on line 6, but perhaps I'm missing something obvious. Any ideas? Regards, Anand From lists at peter.de.com Thu Aug 14 08:33:16 2014 From: lists at peter.de.com (Oliver Peter) Date: Thu, 14 Aug 2014 10:33:16 +0200 Subject: [dsc] DSC's collector fails to compile on CentOS 7 In-Reply-To: <53EB827E.3010807@ripe.net> References: <53EB827E.3010807@ripe.net> Message-ID: <20140814083316.GB8614@mail.opdns.de> On Wed, Aug 13, 2014 at 05:21:34PM +0200, Anand Buddhdev wrote: > Hello DSC users and devs, > > I'm trying to compile DSC on CentOS 7, and it's failing. I'm building > dsc-201203250530. The specific error I get is: > > # cd /builddir/build/BUILD/dsc-201203250530/collector/dsc/ > # ./configure > ... > [ configure output ] > ... > # make > Makefile:6: *** missing separator. Stop. > > This exact sequence works fine on CentOS 6, but fails on CentOS 7. > > If I diff the Makefiles produced by CentOS 6 and CentOS 7, I see: > > < LDFLAGS += # from configure > < CFLAGS += -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic # from > configure > --- > > LDFLAGS += -Wl,-z,relro # from configure > > CFLAGS += -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches > -m64 -mtune=generic # from configure > > > The other difference is that CentOS 6 has make version 3.81, and CentOS > 7 has make version 3.82. > > I can't see anything obviously wrong with the Makefile on line 6, but > perhaps I'm missing something obvious. Any ideas? It looks like GNU makes behaviour has changed, it's easy to fix: Index: collector/dsc/Makefile.in =================================================================== --- collector/dsc/Makefile.in (revision 13833) +++ collector/dsc/Makefile.in (working copy) @@ -3,7 +3,7 @@ CFLAGS=-g -Wall -DUSE_IPV6=1 CPPFLAGS = ${CFLAGS} MYCPPFLAGS = -g -DUSE_IPV6=1 -I $(HAPY)/src/include -I/usr/local/include -TODAY != date +%Y%m%d +TODAY!=date +%Y%m%d INSTALLDIR=/usr/local/dsc LDFLAGS += @LDFLAGS@ # from configure Tested on Centos{6,7} and FreeBSD 10. -- Oliver PETER oliver at gfuzz.de 0x456D688F From petrasch at denic.de Thu Aug 14 12:14:59 2014 From: petrasch at denic.de (Christian Petrasch) Date: Thu, 14 Aug 2014 14:14:59 +0200 Subject: [dsc] dsc Digest, Vol 62, Issue 1 In-Reply-To: References: Message-ID: Hi Anand, i forwarded your question to a colleague of mine with very good c++ knowledge and he had a look: ##################################################### Hi, I don't have CentOS 7, but I could reproduce the Problem on FreeBSD 10 with gnu-make 3.82. Line 6 of makefile is: TODAY != date +%Y%m%d I don't know what the assignment "!=" should do, I've never seen this before. I'm only aware of =, +=, ?= and := (see http://stackoverflow.com/questions/448910/makefile-variable-assignment) If you remove that line (the varaible TODAY is only used when building a tar file from CVS), make 3.82 works for me. The native BSD-make and gnu-make 3.81 don't have any problem with Line 6, so indeed, this seems to be a specific problem/feature of gnu-make 3.82. Best Regards, Patrick ######################################################### I hope we could help you.. hope to see you at Los Angeles or London greetz.. Christian -- Christian Petrasch DENIC eG Kaiserstra?e 75-77 60329 Frankfurt am Main GERMANY Von: dsc-request at measurement-factory.com An: dsc at measurement-factory.com, Datum: 13.08.2014 20:00 Betreff: dsc Digest, Vol 62, Issue 1 Gesendet von: dsc-bounces at measurement-factory.com Send dsc mailing list submissions to dsc at measurement-factory.com To subscribe or unsubscribe via the World Wide Web, visit http://www.measurement-factory.com/mailman/listinfo/dsc or, via email, send a message with subject or body 'help' to dsc-request at measurement-factory.com You can reach the person managing the list at dsc-owner at measurement-factory.com When replying, please edit your Subject line so it is more specific than "Re: Contents of dsc digest..." Today's Topics: 1. DSC's collector fails to compile on CentOS 7 (Anand Buddhdev) ---------------------------------------------------------------------- Message: 1 Date: Wed, 13 Aug 2014 17:21:34 +0200 From: Anand Buddhdev To: "dsc at measurement-factory.com" Subject: [dsc] DSC's collector fails to compile on CentOS 7 Message-ID: <53EB827E.3010807 at ripe.net> Content-Type: text/plain; charset=ISO-8859-1 Hello DSC users and devs, I'm trying to compile DSC on CentOS 7, and it's failing. I'm building dsc-201203250530. The specific error I get is: # cd /builddir/build/BUILD/dsc-201203250530/collector/dsc/ # ./configure ... [ configure output ] ... # make Makefile:6: *** missing separator. Stop. This exact sequence works fine on CentOS 6, but fails on CentOS 7. If I diff the Makefiles produced by CentOS 6 and CentOS 7, I see: < LDFLAGS += # from configure < CFLAGS += -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic # from configure --- > LDFLAGS += -Wl,-z,relro # from configure > CFLAGS += -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic # from configure The other difference is that CentOS 6 has make version 3.81, and CentOS 7 has make version 3.82. I can't see anything obviously wrong with the Makefile on line 6, but perhaps I'm missing something obvious. Any ideas? Regards, Anand ------------------------------ _______________________________________________ dsc mailing list dsc at measurement-factory.com http://www.measurement-factory.com/mailman/listinfo/dsc End of dsc Digest, Vol 62, Issue 1 ********************************** From anandb at ripe.net Thu Aug 14 12:51:58 2014 From: anandb at ripe.net (Anand Buddhdev) Date: Thu, 14 Aug 2014 14:51:58 +0200 Subject: [dsc] DSC's collector fails to compile on CentOS 7 In-Reply-To: <20140814083316.GB8614@mail.opdns.de> References: <53EB827E.3010807@ripe.net> <20140814083316.GB8614@mail.opdns.de> Message-ID: <53ECB0EE.4080000@ripe.net> On 14/08/2014 10:33, Oliver Peter wrote: Hi Oliver, > It looks like GNU makes behaviour has changed, it's easy to fix: > > Index: collector/dsc/Makefile.in > =================================================================== > --- collector/dsc/Makefile.in (revision 13833) > +++ collector/dsc/Makefile.in (working copy) > @@ -3,7 +3,7 @@ > CFLAGS=-g -Wall -DUSE_IPV6=1 > CPPFLAGS = ${CFLAGS} > MYCPPFLAGS = -g -DUSE_IPV6=1 -I $(HAPY)/src/include > -I/usr/local/include > -TODAY != date +%Y%m%d > +TODAY!=date +%Y%m%d This was indeed the problem! Thank you for identifying it! I've created a patch for it, and fed it to our RPM build process, and now it all just builds fine. Thanks also to Christian Petrasch, who emailed separately. His colleague identified the same issue. His suggestion was to delete the line altogether, as it is not needed during the build process. However, I'm keeping the line, and just using your suggestion. Thanks again guys! Regards, Anand